Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle continuous joints in getLowerAndUpperLimits (backport #3153) #3154

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 11, 2024

Description

The RevoluteJointModel returns -pi/pi as position joint limits for continuous joints, which are not position bounded.
This PR fixes getLowerAndUpperLimits to check the position_bounded_ flag and return joint limits accordingly.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3153 done by [Mergify](https://mergify.com).

(cherry picked from commit ecd5d30)

# Conflicts:
#	moveit_core/robot_model/include/moveit/robot_model/joint_model_group.hpp
#	moveit_core/robot_model/src/joint_model_group.cpp
@mergify mergify bot added the conflicts label Dec 11, 2024
Copy link
Author

mergify bot commented Dec 11, 2024

Cherry-pick of ecd5d30 has failed:

On branch mergify/bp/humble/pr-3153
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit ecd5d3007.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   moveit_core/robot_model/include/moveit/robot_model/joint_model_group.hpp
	both modified:   moveit_core/robot_model/src/joint_model_group.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sea-bass
Copy link
Contributor

Ah, this functionality was not introduced until #2861 -- this backport is not compatible with Humble.

@sea-bass sea-bass closed this Dec 11, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d13d835) to head (f50a319).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble   #3154       +/-   ##
==========================================
- Coverage   42.26%       0   -42.25%     
==========================================
  Files         668       0      -668     
  Lines       57740       0    -57740     
  Branches     7322       0     -7322     
==========================================
- Hits        24398       0    -24398     
+ Misses      33157       0    -33157     
+ Partials      185       0      -185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants