Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable flaky PSM test #3124

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Re-enable flaky PSM test #3124

merged 3 commits into from
Nov 22, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 22, 2024

Description

Re-enables a flaky Planning Scene Monitor test, adding a wait between the thread being started in the SetUp() to avoid race conditions I could reproduce locally.

Terminal 1:

stress -c 16 --vm 20 --vm-bytes 256M --timeout 10000 

Terminal 2:

ros2 test /home/sebastian/workspace/moveit_ws/src/moveit2/moveit_ros/planning/planning_scene_monitor/test/launch/planning_scene_monitor.test.py test_binary_dir:=/home/sebastian/workspace/moveit_ws/build/moveit_ros_planning/planning_scene_monitor

See log of retries being tracked here: https://github.com/moveit/moveit2/actions/runs/11966295919/job/33361693036?pr=3124 -- humble CI failing for other reasons on main as of the last few days.

Mitigates (but does not close) #2821

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass changed the title Re-enable flaky PSM test and increase timeout Re-enable flaky PSM test Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.58%. Comparing base (6d94dfb) to head (85f5c7f).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
- Coverage   45.80%   45.58%   -0.21%     
==========================================
  Files         483      482       -1     
  Lines       40631    40432     -199     
==========================================
- Hits        18608    18428     -180     
+ Misses      22023    22004      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sea-bass sea-bass marked this pull request as ready for review November 22, 2024 04:48
@sea-bass sea-bass requested a review from sjahr November 22, 2024 14:02
@sea-bass sea-bass merged commit d754dbd into main Nov 22, 2024
12 of 13 checks passed
@sea-bass sea-bass deleted the restore-psm-test branch November 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants