Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[moveit_servo] fix: ensure ee_pose on planning_frame #3046

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

patrickKXMD
Copy link
Contributor

Description

When calculating jointDeltaFromPose after receiving a pose target for moveit servo, the ee_pose is not always on planning_frame.
This patch will ensure the ee_pose is based on right frame.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

Wete you able to still run the pose tracking demo after this change?

@patrickKXMD
Copy link
Contributor Author

LGTM! Thank you.

Wete you able to still run the pose tracking demo after this change?

Hi I didn't run the pose tracking demo.

I test this in my own project which uses pose command servoing

@sjahr sjahr added this pull request to the merge queue Oct 31, 2024
Merged via the queue into moveit:main with commit d5f763e Oct 31, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants