Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If I use the moveit_servo servo_node in combination with Gazebo simulation, the
moveit_ros.current_state_monitor
complains that it doesn't receive robot state with recent timestamp. I launch all nodes with the 'use_sim_time' set to True, however the current_state_monitor still seems to use wall time. A similar problem was explained in this issue, although not for moveit_servo:#2906
My solution is to change the code from
rclcpp::Clock(RCL_ROS_TIME).now()
tonode_->now()
, such that the time is obtained from the node, which is launched with 'use_sim_time' set to True, so that it gives the sim time. This fixes my problem for the moveit_servo node, but will probably not fix the problem in the issue I mentioned.This is my first contribution. I would like to hear feedback about this suggested change!
Checklist