Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty tables in zoom poll results #897

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions parsons/zoom/zoom.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ def __process_poll_results(self, tbl: Table) -> Table:
`Returns`:
Parsons Table
"""
if tbl.num_rows == 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally pedantic and not important, but since the merge of #830, could use the more python if not len(tbl):

return tbl

# Add surrogate key
tbl.add_column("poll_taker_id", lambda _: str(uuid.uuid4()))
Expand Down