Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Builder Entity Record Insert Name Key Hotfix #887

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ydamit
Copy link
Contributor

@ydamit ydamit commented Sep 6, 2023

Action Builder's API is not consistent about what key you need in your data for the name of the entity. For People (and other Entities configured like them) you need at least a given_name key. Other Entity types can be configured just to take a single name. These used to be insertable with the name key, but now seem to require action_builder:name. Rather than trying to force that prefix to be added, I'm just making sure all three keys pass the error handling in insert_entity_record().

@ydamit ydamit added the bug fix Work type - fixes existing bug label Sep 6, 2023
Copy link
Contributor

@IanRFerguson IanRFerguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@ydamit ydamit merged commit 5d64a68 into main Sep 6, 2023
5 checks passed
@ydamit ydamit deleted the yotam-bldr-insert_namecheck_hotfix branch September 6, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Work type - fixes existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants