-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Nation Builder Connector #837
feat: add Nation Builder Connector #837
Conversation
a1ec55e
to
0210775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in Slack, this needs documentation (see an example here). Do you know how hard it is to become a certified developer? I'd love to be able to do a live test but if that's too much of a hassle we can figure something else out.
- get_people gets all people in NB account
1cc50f9
to
756ee7f
Compare
Just added the necessary docs using the ActBlue page as a template. I think it's complete and clear but let me know if something else is needed. We can schedule a quick call and I can run a few test scenarios using our live NB account. I'm on Slack so you can contact me there to coordinate. We have not explored becoming certified developers since what we are building is for our own internal use. I have a weekly meeting with NB I will bring that up and let you know. The CI failure looks unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Giovanni, just making a note that once you add the mock tests, we should be good to merge.
@shaunagm just added the additional tests using fixtures. Please do let me know if you need additional changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds a new Nation Builder connector.
The connector implements the following public methods:
get_people
: make all necessary HTTP request to get all people and return aTable
. If a request fails, it will wait 30 seconds and keep trying until it fetches everything.update_person
: update a person by their Nation Builderid
.upsert_person
: update or create a person.Examples
The following examples help illustrate the API usage.