added encoding to s3_copy function in redshift class #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyraedy
reviewed
Jun 1, 2023
shaunagm
requested changes
Jun 23, 2023
|
So the instructions for how to use Black in the docs are wrong, whoops. Can you try |
* fix black error * Bump Multiple Docs Deps Around Sphinx (#975) * Bump multiple docs deps * Downgrade myst-parser --------- Co-authored-by: Soren Spicknall <[email protected]>
|
@sharinetmc can you double-check that I resolved the merge conflict correctly and that the function does what it should? 0fb5ab3 If you can confirm that, we can merge this |
|
@shaunagm, tests are all passing now and everything looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.