Specify version of slackclient in setup.py #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @crayolakat! Tagging in @cmc333333 to help review this one. |
cmc333333
reviewed
May 30, 2023
Co-authored-by: CM Lubinski <[email protected]>
shaunagm
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Sorry for the delay, @crayolakat, I meant to do this after the meeting last week and forgot.
talevy42
pushed a commit
to talevy42/parsons
that referenced
this pull request
Jul 8, 2023
* Specify version * Make dependency looser Co-authored-by: CM Lubinski <[email protected]> --------- Co-authored-by: CM Lubinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
pip install parsons[slack], the latest version of slackclient is installed (2.9.4). The version of slackclient specified inrequirements.txtis 1.3.0:parsons/requirements.txt
Line 6 in 853b27c
In slackclient 2.9.4, the
slackclientmodule has been renamed, causing all references toparsons/notifications/slack.pyto return the errorModuleNotFoundError: No module named 'slackclient'.parsons/parsons/notifications/slack.py
Line 7 in 853b27c
This PR specifies the slackclient version in
setup.pyto be the same version specified inrequirements.txt.