Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #779

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

crayolakat
Copy link
Collaborator

I was getting a segmentation fault when running any and all tests locally. OS: macOS Ventura 13.01. Python version: 3.10.8. See below log:

(parsons-ve) kathynguyen@administrators-MacBook-Pro parsons % pytest -rf test/test_shopify.py
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.10.8, pytest-7.1.1, pluggy-1.0.0
rootdir: /Users/kathynguyen/Documents/GitHub/parsons, configfile: pytest.ini
plugins: requests-mock-1.5.2, datadir-1.3.0
collected 4 items                                                                                                                                             
test/test_shopify.py ....                                                                                                                               [100%]
====================================================================== warnings summary =======================================================================
../../../.pyenv/versions/3.10.8/envs/parsons-ve/lib/python3.10/site-packages/joblib/my_exceptions.py:21
  /Users/kathynguyen/.pyenv/versions/3.10.8/envs/parsons-ve/lib/python3.10/site-packages/joblib/my_exceptions.py:21: DeprecationWarning: TransportableException is deprecated and will be removed from joblib in 0.16
    warn("{} is deprecated and will be removed from joblib "
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================ 4 passed, 1 warning in 1.29s =================================================================
zsh: segmentation fault  pytest -rf test/test_shopify.py

After some digging, it was discovered that the root cause is the google-cloud-bigquery==3.0.1 requirement. This installs pyarrow==7.0.0 which caused the segmentation fault. After upgrading to google-cloud-bigquery==3.4.0, pyarrow will be updated to pyarrow==10.0.1, which will fix the issue. grpcio is also required to by updated because of the google-cloud-bigquery update

@shaunagm
Copy link
Collaborator

Sorry for the delay in reviewing and merging this. My main concern is that this fixes things for your setup but may cause problems for others.

It's on my to-do list to add "install Parsons in all common environments" to the checks but I haven't done that yet... in fact I just added it as an issue #790. I'm going to go ahead and merge this and hope for the best. And in the future hopefully we'll have better tests for this kind of change.

@shaunagm shaunagm merged commit cf625bf into move-coop:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants