Updates to ActionKit, S3, and NGPVan #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update setup_google_application_credentials to support dict parameter
…egation The oauth2client library is deprecated, and gspread will drop most information from the oauth2client authorization. Switch to the actively maintained google-auth library and add an argument for a delegated account name.
Update authorization library for Google Sheets to support account del…
Update authorization library for Google Sheets to support account delegation
Don't auto-grab session token if it's not passed in
The new method paginated_get expands get_events to work for any type of object, and get_events has been updated to refer to paginated_get. In addition, a new method, paginated_get_custom_limit, allows for truncating the data based on the value of a field, rather than a fixed set of results. For example, this would allow you to return all users created within the last day. (Some fields which permit ordering may not permit filtering, which is why this can't be accomplished with a simple filter.) Tests have also been written for the new methods. Names of methods and arguments are not final and could use some work; suggestions welcome.
Modeled on transaction search. Test data obtained by editing the subscription gateway to print the search response (https://github.com/braintree/braintree_python/blob/fc98c738f9e74736a7d1e82cfb4e37f6e493c3c4/braintree/subscription_gateway.py#L59).
Add subscription search to Braintree
Add new general object search methods to ActionKit
Update from upstream branch
S3 gets initialized from inside the Redshift code, so add the option to the Redshift setup as well.
Fix import and linting issues
Add use_env_token option to Redshift
Add method to cancel recurring orders
Return status code for recurring order cancel
Add contact notes API for NGP VAN connector
Update from upstream branch
Merged
Merged
Add create_transaction method to ActionKit
shaunagm
requested changes
Dec 1, 2022
There was a problem hiding this comment.
Sorry for the delay in reviewing! Overall this looks great—my only question is around test coverage. Only one of the three new ActionKit methods has a test, and the new NGPVAN class has two methods, neither of which have tests. Is there a reason not to include tests for these things?
|
Hey @shaunagm , no reason not to have tests. I can add them |
|
Thank you! |
Update moveon's branch w/ upstream repo
Add tests for ActionKit and Van
|
Hey @shaunagm , I added the tests |
SorenSpicknall
approved these changes
Dec 6, 2022
shaunagm
approved these changes
Dec 7, 2022
|
Awesome, thank you @crayolakat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancel_orderrecurringandupdate_paymenttokenfunctions to ActionKit connectoruse_env_tokenparameter to S3 initializer