NGPVAN: Saved List Overwrite Bug Fix #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jburchard
added
the
bug
SorenSpicknall
requested changes
Oct 26, 2022
|
Hey @jburchard, do you happen to have any time coming up to fix these small linting issues? If not, I can do it myself - just didn't want to mess with the branch history if you were planning on coming back to it. |
|
I can pick this up after Thanksgiving.
…On Fri, Nov 18, 2022 at 12:23 AM Soren Spicknall ***@***.***> wrote:
Hey @jburchard <https://github.com/jburchard>, do you happen to have any
time coming up to fix these small linting issues? If not, I can do it
myself - just didn't want to mess with the branch history if you were
planning on coming back to it.
—
Reply to this email directly, view it on GitHub
<#770 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKGDOYLO34ZC2RTKPWMQJDWI2H2JANCNFSM6AAAAAARORG5ZU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
SorenSpicknall
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the code that would not allow you to overwrite a list. Also, cleaned up a copy/paste typo in the logging.