Fix error in VAN Target Export method. #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this method assumes VAN return a *list* of exported files rather than a single target, but VAN currently only returns individual targets: https://docs.ngpvan.com/reference/targetexportjobsexportjobid They might've changed the API since this was last updated? In any event, these tweaks return correct data in my recent testing!
cmc333333
changed the title
bzupnick
approved these changes
Jun 25, 2022
|
Found another little optimization: rather than downloading the whole file into memory, we can let petl do its lazy loading thing. |
SorenSpicknall
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this method assumes VAN return a list of exported files
rather than a single target, but VAN currently only returns individual
targets: https://docs.ngpvan.com/reference/targetexportjobsexportjobid
They might've changed the API since this was last updated? In any event,
these tweaks return correct data in my recent testing!