Add missing check to distinguish between path string and json string in Google connector utility #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-doing this PR due to deleted fork weirdness.
I think I figured out the issue that I and others were having with Google authentication. A previous PR changed the way the utilities.py file worked and all strings, including path strings, were being interpreted as json strings. So when we set a path as the environmental variable, setup_google_application_credentials saved it as though it was itself the json credentials file, which of course led to parsing errors down the line.
I'd like to get this reviewed and a new release cut relatively quickly, as until this is released on pypi anyone trying to set up the google connector is going to run into errors.