Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to filter expand_fields before stringifying them #700

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

shaunagm
Copy link
Collaborator

@shaunagm shaunagm commented Jun 8, 2022

Two years ago, filter logic was added to the get_person VAN method to remove fields that didn't exist on particular databases. Unfortunately, it was added after the logic which turns expand_fields from an array into a string, leading to weirdness like this:

Screenshot from 2022-06-08 18-13-06

This in turn leads to 404 errors. Has get_person just always returned 404 errors for the last two years? Is no one using the expand_fields parameter? Have people been silently working around this? I am deeply curious.

Note: this PR also makes it so the print statement displays vanid instead of none when a vanid is passed in.

@shaunagm
Copy link
Collaborator Author

shaunagm commented Jun 8, 2022

Note: this may be related to #673

Copy link
Collaborator

@SorenSpicknall SorenSpicknall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I'm also very curious about what people were doing up to this point, especially since it's such a heavily used connector.

@SorenSpicknall SorenSpicknall merged commit 2a6ee7b into main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants