Attempt to filter expand_fields before stringifying them #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two years ago, filter logic was added to the
get_person
VAN method to remove fields that didn't exist on particular databases. Unfortunately, it was added after the logic which turnsexpand_fields
from an array into a string, leading to weirdness like this:This in turn leads to 404 errors. Has
get_person
just always returned 404 errors for the last two years? Is no one using theexpand_fields
parameter? Have people been silently working around this? I am deeply curious.Note: this PR also makes it so the print statement displays
vanid
instead of none when a vanid is passed in.