Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in environment variable #1093

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

austinweisgrau
Copy link
Collaborator

This typo entered in 6dfaaec

austinweisgrau referenced this pull request Jul 15, 2024
…onment variable (#1040)

* Fix typo in filename utitities > utilities

* New method to pass credentials directly to GCP clients

* Pass credentials explicitly to Google clients

Avoids issue documented in #1039 where credentials for all GCP clients
are stored in the same environment variable, leading to overwrites if
multiple clients are initialized in the same environment.

* Mock credential parsing in tests

Avoids mock credentials needing to match Google Service Account
credential parsing

* Refactor Google Admin using new authed request session

* Fix tests on GoogleAdmin, expect new response structure

* Small changes to get BigQuery tests working
Copy link
Contributor

@cmdelrio cmdelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating

@cmdelrio cmdelrio merged commit e56819a into move-coop:main Jul 15, 2024
18 checks passed
@austinweisgrau austinweisgrau deleted the gcp_hotfix branch July 15, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants