Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance and fix Zoom methods #1092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhance and fix Zoom methods #1092

wants to merge 2 commits into from

Conversation

austinweisgrau
Copy link
Collaborator

This PR makes two changes to the Zoom connector.

  • get_meetings() takes new optional arguments to date filter results
  • the post processing on the get_past_meeting_poll_metadata method is fixed

IanRFerguson
IanRFerguson approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@IanRFerguson IanRFerguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig it!

shaunagm
shaunagm requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor docstring update needed, plus the tests will need to pass before we can merge

@austinweisgrau
Copy link
Collaborator Author

Weirdly I'm not able to reproduce this test_gmail.py error locally but will dig in when I have a moment

@shaunagm
Copy link
Collaborator

Oh interesting, we were getting this in #1132 and assumed it was from a change in that PR (cc @bmos)

@austinweisgrau austinweisgrau force-pushed the zoom_polls branch 3 times, most recently from f417e6e to cce145e Compare October 16, 2024 00:59
@shaunagm
Copy link
Collaborator

This looks ready to merge to me! Is it good on your end?

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  parsons/zoom
  zoom.py 209-215
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunagm shaunagm shaunagm approved these changes

@IanRFerguson IanRFerguson IanRFerguson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinweisgrau @shaunagm @IanRFerguson