Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GET helper function, add custom columns to create profile #1055

Merged
merged 5 commits into from
May 23, 2024

Conversation

cmdelrio
Copy link
Contributor

@cmdelrio cmdelrio commented May 15, 2024

  1. Update GET helper function - There was a small bug in the logic for get endpoints where pagination is controled with a "num" page indicator. In short, line 140 was returning false when it should have been returning true!
  2. Correct phone_numbers aspect of get_profiles - turns out mobile commons accepts a comma separated string of phone numbers, not a list.
  3. Added the option to write custom column data to profiles in the create_profiles method. Also updated documentation to indicate that the create_profiles method can also be used to update existing records. Considered creating a new method all together for update_profile, but it seemed a little bit redundant...

@cmdelrio cmdelrio added enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage bug fix Work type - fixes existing bug labels May 15, 2024
Copy link
Contributor

@jeffjrodriguez jeffjrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightforward, approving

@shaunagm shaunagm merged commit d3a8c8d into main May 23, 2024
14 checks passed
@cmdelrio cmdelrio deleted the cormac-mobilecommons-additions branch May 28, 2024 15:24
@cmdelrio
Copy link
Contributor Author

Thank you @jeffjrodriguez and @shaunagm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Work type - fixes existing bug enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants