Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a data paste function to Google Sheets #1045

Merged
merged 9 commits into from
May 14, 2024

Conversation

anzelpwj
Copy link
Contributor

Hi all,

Following up on issue #1036 . I tried initially modifying the append_to_sheet function, but it became clear that this is simply asking too much for one function, so I made a new method paste_data_in_sheet instead.

I don't have access to the Google Sheets sandbox, so for now test_paste_data_in_sheet has not been confirmed to work as expected (but I have done some testing with my own spreadsheet).

Any advice on how I've designed this/getting this code ready for merging would be much appreciated, thank you!

@anzelpwj
Copy link
Contributor Author

Why are imports failing for modules I haven't touched?

@NirTatcher
Copy link
Contributor

NirTatcher commented Apr 29, 2024

Why are imports failing for modules I haven't touched?

What version of Python are you running?
I get the same error when I'm on an incompatible python version , make sure it matches the current python version requirements:
python_requires=">=3.7.0,<3.12.0"

Hope this would be helpful!

@anzelpwj
Copy link
Contributor Author

Why are imports failing for modules I haven't touched?

What version of Python are you running? I get the same error when I'm on an incompatible python version , make sure it matches the current python version requirements: python_requires=">=3.7.0,<3.12.0"

Hope this would be helpful!

It runs fine on my machine (Pop!_OS, Python 3.10.14). What I'm confused about is the CI/CD failure at https://github.com/move-coop/parsons/actions/runs/8869754280/job/24350778446?pr=1045

@anzelpwj anzelpwj marked this pull request as draft April 29, 2024 15:30
@anzelpwj
Copy link
Contributor Author

I will note that #1044 also failed at the same step and in the same way.

parsons/google/google_sheets.py Show resolved Hide resolved
parsons/google/google_sheets.py Show resolved Hide resolved
parsons/google/google_sheets.py Show resolved Hide resolved
test/test_google/test_google_sheets.py Outdated Show resolved Hide resolved
@anzelpwj anzelpwj marked this pull request as ready for review May 4, 2024 00:44
@anzelpwj anzelpwj changed the title WIP: Adding a data paste function to Google Sheets Adding a data paste function to Google Sheets May 4, 2024
@anzelpwj anzelpwj requested a review from shaunagm May 7, 2024 22:09
Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making these changes

@shaunagm shaunagm merged commit a40d332 into move-coop:main May 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants