Removes bluelink connector because platform retired March 2024 #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinweisgrau
requested changes
Apr 12, 2024
parsons/__init__.py
Outdated
| @@ -93,7 +92,9 @@ | |||
| ("parsons.zoom.zoom", "Zoom"), | |||
| ): | |||
| try: | |||
| globals()[connector_name] = getattr(importlib.import_module(module_path), connector_name) | |||
| globals()[connector_name] = getattr( | |||
There was a problem hiding this comment.
I think this change here breaks the linting. potentially relevant is that a recent PR upgraded us from black 22 to black 24, which has some differences in how it lints files
|
Also I'd prefer if the commit message was more explicit like "Removing the bluelink connector because the platform has closed" or something |
|
@austinweisgrau I'm not sure how to edit a commit message, but added a description to the PR. |
austinweisgrau
changed the title
austinweisgrau
changed the title
austinweisgrau
pushed a commit
to austinweisgrau/parsons
that referenced
this pull request
Apr 22, 2024
…coop#1034) Removing the bluelink connector because the platform was retired in March of 2024. --------- Co-authored-by: Elyse <[email protected]>
austinweisgrau
pushed a commit
to austinweisgrau/parsons
that referenced
this pull request
Apr 22, 2024
…coop#1034) Removing the bluelink connector because the platform was retired in March of 2024. --------- Co-authored-by: Elyse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the bluelink connector because the platform was retired in March of 2024.