Bugfixes #1012
Merged
Bugfixes #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instance checks use `isinstance()`
|
@bmos sorry for taking so long to respond, I've been traveling. Have you made any changes to the docs other than linting? It's hard to see in the diffs if there's anything other than line length changes. Otherwise everything looks good to me. |
shaunagm
approved these changes
Apr 4, 2024
|
Only formatting changes and can revert those files if preferred. |
|
No need to revert, just wanted to make sure I wasn't missing anything. |
shaunagm
reviewed
Dec 9, 2024
| oauth2client==4.1.3 | ||
| google-auth==2.6.2 | ||
| dbt_redshift==1.4.0 | ||
| docutils<0.18,>=0.14 |
There was a problem hiding this comment.
I think it's been that way since before my time and the only reason that it's changed by this PR is because I alphabetized the requirements.
I would try removing it from requirements altogether and let Sphinx install it as a dependency.
There was a problem hiding this comment.
git blame letting me down :( I will give it a try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In more in-depth refactoring I'm looking into, I have come across a number of changes needed to get tests passing, resolve test warnings, and obey lints. As requested in #1009, I have taken all the minor bugfixes and compiled them here.
ddccd1e also fixes the only remaining issue holding back 3.11 support! So I added it to setup.py and the test suite to demonstrate that.