Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable dependencies #217

Open
leandro-lucarella-sociomantic opened this issue Feb 13, 2019 · 21 comments
Open

Vulnerable dependencies #217

leandro-lucarella-sociomantic opened this issue Feb 13, 2019 · 21 comments

Comments

@leandro-lucarella-sociomantic
Copy link
Collaborator

See https://github.com/sociomantic-tsunami/flounder/network/alerts

Please update.

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

It looks like this project is abandoned. Shall we archive it to make that clear for the general public?

@mousemke
Copy link
Owner

i have:

so it does not bother me one way or another whether the Soc side of things stays active (Though i've enjoy working with Soc DH, it does appear abandoned from that side)

as we use it in some areas in Zalando i will continue to maintain and (occasionally) update my branch

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

If we don't use it internally, I would also be open to transfer the repo to another organization if you plan to keep maintaining it.

@damian-rodriguez-sociomantic
Copy link
Collaborator

damian-rodriguez-sociomantic commented Feb 14, 2019

@leandro-lucarella-sociomantic we are still using an old version of flounder in some parts of the UI, but eventually it will be removed, and yes, the development/maintenance from our side is abandoned.

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

@damian-rodriguez-sociomantic so a transfer/archival should be OK as long as:

  • the old versions are still provided by the new maintainer if we transfer it
  • the old versions can be still checked out via git if we archive it

Right?

@damian-rodriguez-sociomantic
Copy link
Collaborator

@leandro-lucarella-sociomantic yes, it should be fine

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

@mousemke can you confirm if you are interested in getting this repo transferred to you/Zalando? If you are then I need to find out if I can actually do it (at the Dunnhumby side). Otherwise we will archive it.

@mousemke
Copy link
Owner

confirmed

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

We will move forward with the transfer, and then we fork it from you in our org to make sure we can access the code as long as we need. @mousemke should we transfer to https://github.com/zalando or to https://github.com/mousemke?

@mousemke
Copy link
Owner

mousemke commented Apr 9, 2019

mousemke. thanks!

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

leandro-lucarella-sociomantic commented Apr 9, 2019

You should rename remove your fork then:

The target account must not have a repository with the same name, or a fork in the same network.

https://help.github.com/en/articles/transferring-a-repository

All users of this repo should also read that whole guide, as they should update their git URLs in their clones for example.

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

If you are uncomfortable with that we could also just add a note to the README saying the project moved and archive this one.

@mousemke
Copy link
Owner

mousemke commented Apr 9, 2019

renamed

@mousemke
Copy link
Owner

mousemke commented Apr 9, 2019

ah. saw the edit. one sec

@mousemke
Copy link
Owner

mousemke commented Apr 9, 2019

removed

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

You can only transfer a repository from an organization to yourself at this time

Really, GitHub? 🙄

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

Is not even mentioned in the guide, so I wonder if it is a temporary limitation or an undocumented limitation. I could try asking to GH support, I'll try.

@mousemke
Copy link
Owner

mousemke commented Apr 9, 2019

lol it's always something

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

OK, GitHub never got back to me so I went through the triangle. You should get a transfer request from my user.

@leandro-lucarella-sociomantic
Copy link
Collaborator Author

OK, just for the records, transfer done. This issue is now on your hands @mousemke :)

@mousemke
Copy link
Owner

mousemke commented Apr 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants