Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Domain Layer / Domain Model #93

Merged
merged 47 commits into from
Jan 18, 2024
Merged

Feature / Domain Layer / Domain Model #93

merged 47 commits into from
Jan 18, 2024

Conversation

dncsvr
Copy link
Member

@dncsvr dncsvr commented Jan 9, 2024 •
edited
Loading

Complete implementation of DomainModel for service registration and orm mapping

💡 Discussion

  • As a Proof of Concept, implement a business feature that registers public
    business classes to service collection.
  • Provide an API for features and layers to enumerate on domain types through
    a set of reflection helper classes.

Tasks

  • Register services using domain model in a business feature implementation
    • Add RegisteringServices test fixture
      • Types containing With methods should be registered as transient with singleton factories
      • Types should have no or all dependency parameters in primary constructors are registered as singleton
      • Types with IQueryContext<> dependencies should be registered as singleton
      • Abstract types should not be registered,
      • Static types should not be registered,
      • Value types should not be registered
      • Records should not be registered
      • Exceptions should not be registered
      • System types should not be registered
      • Attributes should not be registered
    • Edit business feature and domain models
      • Add IsAbstract and IsValueType properties to TypeModel
      • Add PropertyModel
      • Add ParameterModel
      • Build TypeModels for interfaces
      • Add custom attribute infos to type and method models
      • Add parameters to method models
      • Return types should be TypeModel
      • Move domain model build logic to BuildDomain phase
      • Add DomainBuilderOptions for configuring build
      • Add AttributeModel
      • OverloadModel for methods and constructors
      • Model child lists should be immutable

@dncsvr dncsvr self-assigned this Jan 9, 2024
@dncsvr dncsvr mentioned this pull request Jan 9, 2024
Merged
9 tasks
dncsvr added 19 commits January 9, 2024 16:11
@dncsvr
temporarily remove DefaultBusinessFeature service registration logic
157cbd8
@dncsvr
add registering service test cases !!! TESTS FAILING !!!
d9868cb 
 - add classes for tests
@dncsvr
edit RegisteringServices
7bcc37a 
- rename local variables to actual
- minor fixes
@dncsvr
revert DefaultBusinessFeature implementation
0bede51
@dncsvr
add abstract type test case
62a1ed7
@dncsvr
fix failing tests
9148cf1 
- add _IsAbstract_ and _IsValueType_ properties to `TypeModel`
- add `PropertyModel`
@dncsvr
add new test case for registering services !!! TESTS FAILING !!!
10a69c3
@dncsvr
fix failing tests
74863e7
@dncsvr
edit default business feature
485e20d
@dncsvr
refactoring DomainModel !!! INCOMPLETE && BUILD AND TESTS FAILING !!!
e35b808 
- move build logic from model dto's
- edit model dto properties
@dncsvr
fix failing build and tests
276c1db
@dncsvr
refactoring domain model
4eb8d23 
- add model collection
- add IModel interface
@dncsvr
refactoring domain model
52f71b0 
- change IModel.Name => Id
- add custom attributes to type and method
- minor edits and refactoring
@dncsvr
refactori domain model build logic
d5f4ddd 
- minor edits
@dncsvr
refactor ModelCollection
1184a08 
- use keyedcollection in model collection
- fix model ids
- minor edits
@dncsvr
add DomainOptions for domain model configuration
eafaca9 
- add ConfigureDomainOptions extension
- configure options in default business feature
@dncsvr
add DomainOptions to documentation
77eebc6
@dncsvr
minor edits
8ae422d
@dncsvr
implement ITypeSource in DomainModel
e3df661
@dncsvr dncsvr requested a review from cihandeniz January 15, 2024 14:58
cihandeniz
cihandeniz reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@cihandeniz cihandeniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is much to review, for now fix these, we'll continue

src/blueprints/Do.Blueprints.Service.Application/Business/Default/DefaultBusinessFeature.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Business/Default/DefaultBusinessFeature.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Domain/DomainLayer.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Domain/DomainLayer.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Domain/Model/AssemblyModel.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/Business/RegisteringServices.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/Business/RegisteringServices.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Domain/Model/DomainModel.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Orm/Default/DefaultOrmFeature.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Domain/Model/TypeModel.cs Outdated Show resolved Hide resolved
dncsvr added 6 commits January 16, 2024 11:16
@dncsvr
change AssemblyModel from record to class
36a56ba
@dncsvr
remove unnecessary apply and remove ITypeSource implementation from…
b4e0121 
… `DomainModel`
@dncsvr
change TypeModel.Apply() to public
536f717
@dncsvr
set Id values instead of being calculated
196e700
@dncsvr
review changes !!! RUN & TESTS FAILING !!!
2844d8e 
- remove `ApplicationContext` from `TestServiceSpec`
- remove `GetServiceDescriptor()` extension
- change tests to use stubber to get services
- make ModelCollection.TryGetValue() public
- change TypeModel from record to class
- move IdFromType helper to TypeModel, can be deleted later
@dncsvr
revert changes in DependencyInjectionExtensions
8aa09bf
dncsvr added 16 commits January 16, 2024 14:20
@dncsvr
add OverloadModel for storing data for each method overload
1b470f0 
- change DomainModelExtensions to inline helper methods
- fix `ClassDTO` constructor parameter names
@dncsvr
fix failing tests !!! RUN FAILING !!!
b628b23 
- add `BaseType`to `TypeModel`
-  add `IsAssignableFrom` helper to `TypeModel`
- remove `Distinct()`
@dncsvr
fix failing run
4344483
@dncsvr
minor edits
7b4ba17
@dncsvr
minor bug fix
a9b36b9
@dncsvr
change IsAssignableFrom => IsAssignableTo
f81927e
@dncsvr
add AttributeModel and ValueModel
65133b2 
- edit model properties to `AttributeModel`
@dncsvr
refactoring method model and overloads
de06a75 
- remove ConstructorModel
- move access properties and returntype to OverloadModel
@dncsvr
edit ModelCollection to be immutable
baf0f26 
- add DomainModelBuilder and move build logic from DomainModel
- remove ModelCollection add methods
- DomainOptions => DomainBuilderOptions
- add Init method to TypeModel
@dncsvr
minor edits
2294b42
@dncsvr
review changes
7caaedf 
- update docs
- remove `ClassDTO` and test case
- remove `IsAssignableTo` helper
- add `GiveMe.TheService<T>` helper
- minor edits
@dncsvr
remove ValueModel
9232e8c 
 - minor edits
@dncsvr
rename parameter
9f2f84b
@dncsvr
minor test edit
28e031b
@dncsvr
add attributes should not be registered test case
16edca7
@dncsvr
update business feature docs
d8ec950
@dncsvr dncsvr requested a review from cihandeniz January 18, 2024 14:35
@dncsvr dncsvr marked this pull request as ready for review January 18, 2024 14:36
dncsvr added 5 commits January 18, 2024 17:51
@dncsvr
review changes
341e363 
- Remove `AttributeModel`
- Add _FullName_ property to `AssemblyModel`
- Add _FullName_ property to `TypeModel`
@dncsvr
review changes
c555734 
- make Id's explicit for models
- make KeyedModelCollection public
- edit DomainModelBuilder => use KeyedModelCollection
@dncsvr
refactor registering services tests
1acc8ac 
 - use GiveMe.The helpers
- remove TheService helper
@dncsvr
refactor domain model builder
266e743
@dncsvr
refactor DomainModelBuilder
ead034a 
- remove type is built conventions from `DomainBuilderOptions`
- remove Type and Assembly descriptors
@dncsvr dncsvr merged commit b72ae68 into mouseless:epic/domain-layer Jan 18, 2024
5 checks passed
@dncsvr dncsvr deleted the feature/domain-layer/domain-model branch January 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cihandeniz cihandeniz cihandeniz approved these changes

Assignees

@dncsvr dncsvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dncsvr @cihandeniz