Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue / Better Error for Corrupted Json #78

Merged
merged 11 commits into from
Nov 23, 2023
Merged

Issue / Better Error for Corrupted Json #78

merged 11 commits into from
Nov 23, 2023

Conversation

SeferMirza
Copy link
Contributor

@SeferMirza SeferMirza commented Nov 22, 2023 •
edited
Loading

When a content is not a proper json in db, it should give a better error
message.

Tasks

  • Reproduce error
  • Catch exception and throw a meaningful exception with message
  • Handle GenericADOExceptionHandler exceptions and throw inner exception when objectusertype
    deserialize fail

@SeferMirza SeferMirza self-assigned this Nov 22, 2023
@SeferMirza SeferMirza marked this pull request as ready for review November 22, 2023 13:50
@SeferMirza SeferMirza requested a review from a team November 22, 2023 13:50
@SeferMirza SeferMirza merged commit 3233219 into mouseless:main Nov 23, 2023
@SeferMirza SeferMirza deleted the issue/better-error-for-corrupted-json branch November 23, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cihandeniz cihandeniz cihandeniz approved these changes

Assignees

@SeferMirza SeferMirza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeferMirza @cihandeniz