Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue / Enum String Response #52

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Issue / Enum String Response #52

merged 9 commits into from
Sep 15, 2023

Conversation

SeferMirza
Copy link
Contributor

@SeferMirza SeferMirza commented Sep 14, 2023 •
edited
Loading

Enum responses should be in string value, not int value.

Tasks

  • create case (entity controller already has examples)
  • fix issue

Additional Tasks

  • ConvertEnumToStringSchemaFilter.cs issues
    • It should use ToLowerInvariant
    • It should use var on the left side
  • library update

@SeferMirza SeferMirza marked this pull request as ready for review September 14, 2023 12:44
@SeferMirza SeferMirza merged commit 5c89230 into mouseless:main Sep 15, 2023
@SeferMirza SeferMirza deleted the issue/enum-string-response branch September 15, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cihandeniz cihandeniz cihandeniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeferMirza @cihandeniz