Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Rich Transients #187

Merged
merged 30 commits into from
Oct 31, 2024
Merged

Feature / Rich Transients #187

merged 30 commits into from
Oct 31, 2024

Conversation

dncsvr
Copy link
Member

@dncsvr dncsvr commented Oct 23, 2024 •
edited
Loading

Introduce RichTransientsCodingStyleFeature for a better transient object
experience.

  • Allow identifiable transients to be parameters just like entities
  • Allow identifiable transients to have their identifier in the route just like
    entities
    • this means their route should be plural as well

Tasks

  • Add RichTransients coding style feature
    • identify transients with With method having a single id parameter
    • render Get if there are any public properties and return object as dto
    • id parameter should be rendered from route
    • pluralize route
    • rich transient can be method parameter
    • command can be initialized with rich transient parameter
    • nullable support
    • update docs

Additional Tasks

  • merge from main
  • Move with params as query convention from CommandPattern to here, as it
    is more relevant
  • Scan project to find additional relevant config/convention/sample code
    etc. to move them under this coding style.
  • enable commands to be initialized with and entity
    • remove method is initializer checks from lookup entity conventions
    • dont use factory method for transient targets
    • command with Entity case: single by id
  • refine compiler error messages
    • display closest scope in hierarchy method or class

@dncsvr dncsvr self-assigned this Oct 23, 2024
dncsvr added 11 commits October 23, 2024 18:30
@dncsvr
implement rich transient coding style - !!! TESTS FAILING !!!
2a9b6ab
@dncsvr
fix failing tests
8e8e51a 
- use `RichTransientAttribute` for markin classes
- add pluralization
@dncsvr
add rich transient with no data sample
4dc31cc 
- rename sample classes
- edit routing rich transients test cases
- add `HasPublicDataAttribute` to mark types with public properties
@dncsvr
merge from main
3f6bb60
@dncsvr
use Locatable attribute in rich transient conventions
427226e 
- remove `RichTransient` attribute
@dncsvr
move initialize using query parameters convention to rich transient f…
bf48f63 
…eature
@dncsvr
merge from main
d29e94b
@dncsvr
refactor rich transient coding style
ccd58ce 
- add find target from initializer convention
- change convention orders to execute before entity and command conventions
- edit routing rich transients samples and test
@dncsvr
add using rich transients as parameters test case
1b8ee83 
- add lookup transients by id conventions
@dncsvr
fix unused parameter issue
2435d70
@dncsvr
minor refactoring
8ead5c1 
- remove `HasPublicData`
- use `CSharpFriendlyFullName` for id types
- fix typos
@dncsvr dncsvr marked this pull request as ready for review October 28, 2024 20:59
@dncsvr dncsvr requested a review from cihandeniz October 28, 2024 20:59
cihandeniz
cihandeniz reviewed Oct 29, 2024
View reviewed changes
dncsvr added 2 commits October 29, 2024 14:51
@dncsvr
review changes
11c8edf 
- remove orm dependency in rich transient conventions
- fix indentation
- use `string` as parameter and return type for rich transient samples
- use `find` instead of `initialize` for id parameter description
@dncsvr
edit rich transient api convention orders closer to 0 when available
405247d
dncsvr added 6 commits October 30, 2024 22:48
@dncsvr
refine compiler diagnostic error messages - !!! RUN AND TESTS FAILING…
f000547 
… !!!
@dncsvr
fix failing run and tests
db81855 
- apply single by unique for only target parameters
- merge rich entity add parameter and find target conventions
- edit diagnostic extensions to return full source if if no node is found
@dncsvr
add rich transient nullable support
a362022 
- add compiler exception message test cases
@dncsvr
add IsTarget helper for parameter model
6c0b5fe
@dncsvr
update coding styles documentation
71e7e92
@dncsvr
use IsTarget helper
c0556bf
@dncsvr dncsvr merged commit 2102b5f into mouseless:main Oct 31, 2024
6 checks passed
@dncsvr dncsvr deleted the feature/rich-transients branch October 31, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cihandeniz cihandeniz cihandeniz approved these changes

Assignees

@dncsvr dncsvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dncsvr @cihandeniz