Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Do.Architecture #14

Merged
merged 61 commits into from
Jul 13, 2023
Merged

Feature / Do.Architecture #14

merged 61 commits into from
Jul 13, 2023

Conversation

cihandeniz
Copy link
Member

@cihandeniz cihandeniz commented Jun 20, 2023 •
edited
Loading

Introduce do-architecture package that implements the core feature and layer
system mentioned in Do / Architecture.

Tasks

  • Find a name for this core system
    • Do.Architecture it is
  • Create classlib and test projects
    • create package and its test project
    • rename test projects to start with Do.Test
  • Implement what has been documented so far
    • add an application builder for Program.cs usage
    • add empty layer builder
    • add empty feature builder
    • refactor existing hello world to use architecture
  • application specs
    • create document for existing specs
    • test hello world
  • layer specs
    • analyse and prepare cases
    • adding phases
    • providing configuration
    • conventions
  • feature specs
    • configuring layers
    • conventions
  • use this kernel to demonstrate how to create an application
    • test/blueprints
    • samples/event-scheduler

Additional Tasks

  • replace Sql with Orm in documents, seems more suitable
  • publish workflow package auto discovery
  • test & coverage workflow
  • samples build workflow
  • Fix logo in readme (nuget doesn't allow do.mouseless.codes)
  • Blueprints and Do.Architecture should add using Do; as an implicit
    using
  • Docs site issues
    • Alert box should have more right padding
    • h2, h3 margin-top should be more
    • diagram subgraphs should have padding
    • font-size and line-height can be smaller for mobile
    • don't wrap long headings in toc, add a trailing dots to fit
    • show scroll for code blocks

@cihandeniz cihandeniz self-assigned this Jun 20, 2023
cihandeniz added 28 commits June 20, 2023 15:40
@cihandeniz
add do.architecture classlib and test projects
5bbc586 
- move package related properties to directory.build.props under src
  folder
@cihandeniz
move do architecture projects in core folder
f9284ea
@cihandeniz
add application and its builder ⚠️ TESTS FAIL ⚠️
0a2ae81 
- upgrade unit test package references
- refactor blueprints.service to use architecture
@cihandeniz
test print banner behaviour
2d54320 
- refactor tests to have a spec and stub model
- rename application test to have a spec name
@cihandeniz
ignore not implemented tests ℹ️ fixes tests ℹ️
2934fe4
@cihandeniz
rename test projects to match new convention
ebae1e5 
- add .editorconfig to have underscore prefix for private
- add .vimspector.json to have debug info
@cihandeniz
add core folder documentation to contributing
3426aba
@cihandeniz
add application documentation
67ee1b6
@cihandeniz
add pseudo code for layer design ⚠️ BUILD FAILING ⚠️
e32c978 
- reorganize tests into their sections
- minor update for application spec
@cihandeniz
implement add layer to application ℹ️ fixes build ℹ️
f8a0b84 
- remove all design sketches
- sync docs with specs
- refactor mocks into MockMe just like stubs in GiveMe
@cihandeniz
implement basic feature addition
1a1e36f 
- refactor mock extensions to return actual object instead of mock
  instance
@cihandeniz
demonstrate a feature implementation ⚠️ TEST FAIL ⚠️
3321a9d 
- rename `Sql` as `Orm` in samples
- minor refactorings
@cihandeniz
design clarification for phases ⚠️ BUILD FAIL ⚠️
8c02719
@cihandeniz
revise phase design and fix src/ build
733fa83 
- tests still fail to build and run
- removed all built-in layers from src/
@cihandeniz
rename http as web in document ℹ️ fixes build ℹ️
3686bd7
@cihandeniz
start implementing phase system ℹ️ fixes test ℹ️
74f56d2 
- minor renames and refactorings included
@cihandeniz
test initialization and application of phases
ca3e90d
@cihandeniz
implement application context tests
a4a0e77
@cihandeniz
implement basic phase order logic
cf4286b
@cihandeniz
implement phase order conflict logic
bf145b9
@cihandeniz
refactor application run logic
5eda4e6
@cihandeniz
finish implementing running an application spec
10b0327
@cihandeniz
implement phase order documentation
e28e1f9 
- refactor and simplify run method
- fix blueprints test case
@cihandeniz
analyse layer spec
c1fdd51
@cihandeniz
start implementing layer/adding-phases
8fc62d1 
- further clarification o nlayer/configuring-layers
@cihandeniz
implement adding phases spec
fc59c52
@cihandeniz
further clarification on layer spec
58460b0 
- add coding standards and naming conventions so far
@cihandeniz
document layer / adding phases spec
9694527 
- rename `CanInitialize` to `IsReady`
- make minor revisions to layer related documentation
cihandeniz added 22 commits July 7, 2023 16:10
@cihandeniz
review changes
d2c9999
@cihandeniz
implement extra cases for application
ea5baf8
@cihandeniz
minor refactorings
81fd60b 
- move service collection dependency from dependency injection layer to
  web layer
@cihandeniz
review changes
b6d967f
@cihandeniz
minor refactoring
ea3f059
@cihandeniz
fix typos in layer doc
6755bb1
@cihandeniz
document conventions
af69065 
- rename `Build` to `Forge`
@cihandeniz
minor revision
8ab26e8
@cihandeniz
feature spec analysis
83a8a74
@cihandeniz
implement feature - configuring layers
b84987d
@cihandeniz
document feature specs
bb48373
@cihandeniz
add release notes for the features and layers
1658f80 
- web and di layers
- greeting feature with hello world and welcome page adapters
@cihandeniz
move existing layers and features from test to src
499b0b2 
- roughly document layers, features and blueprints
@cihandeniz
minor revision in docs
7aa1681
@cihandeniz
add auto discovery for pack and push
5d9b417
@cihandeniz
add coverage and test runs to workflow
9f85fff
@cihandeniz
add samples workflow
ea2166c
@cihandeniz
try fix coverage summary permission
e9f525c
@cihandeniz
remove pr comments from coverage workflow
908491c
@cihandeniz
fix logo path in readme for nuget
9e92327
@cihandeniz
add do namespace to implicit usings
ba12644
@cihandeniz
fix docs issues
a692fe7
@cihandeniz cihandeniz marked this pull request as ready for review July 12, 2023 17:18
@cihandeniz cihandeniz requested review from dncsvr and SeferMirza July 12, 2023 17:19
SeferMirza
SeferMirza approved these changes Jul 12, 2023
View reviewed changes
docs/architecture/README.md Show resolved Hide resolved
@cihandeniz cihandeniz merged commit c97b847 into mouseless:main Jul 13, 2023
@cihandeniz cihandeniz deleted the feature/do-architecture branch July 13, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dncsvr dncsvr dncsvr approved these changes

@SeferMirza SeferMirza SeferMirza approved these changes

Assignees

@cihandeniz cihandeniz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cihandeniz @dncsvr @SeferMirza