Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Communication Beta #100

Merged
merged 27 commits into from
Feb 14, 2024
Merged

Feature / Communication Beta #100

merged 27 commits into from
Feb 14, 2024

Conversation

dncsvr
Copy link
Member

@dncsvr dncsvr commented Feb 9, 2024 •
edited
Loading

Add communication feature and http client layer as a beta feature.

Tasks

  • Add http client layer
  • Add http and mock communication features
  • Add CommunicationFeature documentation

Additional Tasks

  • Add NoTransaction attribute and avoid transaction in middleware

@dncsvr dncsvr self-assigned this Feb 9, 2024
dncsvr added 15 commits February 9, 2024 12:45
@dncsvr
fix failing build
114ffa9
@dncsvr
add HttpCommunication abstractions
3aa93b2 
- add `HttpCommunicationFeature` !!! not implemented !!!
@dncsvr
implement HttpCommunication feature !!! TESTS FAILING !!!
918f7d9
@dncsvr
fix failing tests
7cb6b5d 
- add temporary mock http client implementation
@dncsvr
add MockCommunicatio feature implementation - incomplete
2b8ee57 
- refactor client factory and app settings usage
- move `TimeProviderExtensions` to `Core` folder
@dncsvr
refactor MockCommunication feature implementation
e1ee294 
- add additional `MockCommuncation` feature tests
- minor edits to `ClientFactory`
@dncsvr
refactoring Communication Features
e1d25d9 
- remove default response value and test case
- remove mock client implementation
- convert HttpDescriptor list artifact ro dictionary
- rename ClientFactory => HttpClientFactory
@dncsvr
fix failing build
b38c5fb
@dncsvr
minor edits
d0a10d5
@dncsvr
add HttpClient layer and Communication feature documentations
ca6144b
@dncsvr
minor edits
d69f494 
- client throws exception with an inner exception with response content
@dncsvr
add test endpoint for testing request exception handling !!! TESTS FA…
c5bcd74 
…ILING !!!

- add sample http request exception handler
- add `[NoTransaction]` attribute
@dncsvr
remove test http request exception handler test
b0ea19c 
- cannot perform local calls to test server
@dncsvr
minor edits
9e4d416
@dncsvr
refactoring
0c031bc 
- use `ConfigureHttpClientDefaults` for default builder delegate
- edit documentation
- simlify `HttpClientFactory` and add generic type parameter
@dncsvr dncsvr marked this pull request as ready for review February 12, 2024 15:46
cihandeniz
cihandeniz reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@cihandeniz cihandeniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not my final review.

i think there is more to refactor and simplify especially in default mock settings design.

first work on the comments in this review, then we can refactor it in a discord session

src/blueprints/Do.Blueprints.Service.Application/Communication/Http/Client.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Http/Client.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Http/HttpCommunicationFeature.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Http/HttpCommunicationFeature.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service/Core/TimeProviderExtensions.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/Communication/MockCommunicationFeature.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/TestServiceSpec.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/TestServiceSpec.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/TestServiceSpec.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/TestServiceSpec.cs Outdated Show resolved Hide resolved
@dncsvr
review changes
d493e5d 
- move TimeProviderExtensions to System namespace
- revert ServiceNfr format change
- revert HttpClientExtensions to single line
- Move dictionary extensions to its own file
- return else from FlatTransactionMiddleware
- Add PullRequest record for test client
- Remove GetContentAsObject helper
- Mock Communication feedbacks
cihandeniz
cihandeniz reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@cihandeniz cihandeniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

src/blueprints/Do.Blueprints.Service.Application/Communication/Http/DictionaryExtensions.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Database/FlatTransactionMiddleware.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/Communication/MockCommunicationFeature.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/Communication/MockCommunicationFeature.cs Outdated Show resolved Hide resolved
test/blueprints/Do.Test.Blueprints.Service.Test/TestServiceSpec.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Mock/MockCommunicationFeature.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Mock/MockClientSetup.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Mock/MockClientConfiguration.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Mock/MockClientConfiguration.cs Outdated Show resolved Hide resolved
src/blueprints/Do.Blueprints.Service.Application/Communication/Mock/MockClientConfiguration.cs Outdated Show resolved Hide resolved
@dncsvr
review changes
35d2954 
- add `ClientException`
- refactor `HttpClientLayer` client registration
- rename test spec to `MockingClients`
- refactor builder for mock client setups
- minor edits
@dncsvr
review changes
659d395 
- add GetContentAsObject helper to Request
- Remove MockClientSetup record
- minor edits to MockClientBuilder
@dncsvr
refactor mock communication feature
0b862f5 
- add MockClientSetups
- move ForClient<T> helpers to mock client setups
- change parameter type to MockClientSetups in feature
@dncsvr dncsvr requested a review from cihandeniz February 14, 2024 08:20
@dncsvr dncsvr merged commit 99c1e01 into mouseless:main Feb 14, 2024
6 checks passed
@dncsvr dncsvr deleted the feature/communication-beta branch February 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cihandeniz cihandeniz cihandeniz approved these changes

Assignees

@dncsvr dncsvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dncsvr @cihandeniz