Conditional export support #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mourner,
thank you for the great lib!
I'm faced with the issue of using it with VITE (yet another js bundler) which is using next version of rollup behind the scene.
The problem is that importing your ESM module from 3rd party modules (CJS) causes issues because of the wrong interoperability (
export defaultdoesn't work correctly in this case).I propose to improve your lib by using conditional export, please have a look!
(I checked now it works with Vite and rollup)
Ref: https://nodejs.org/api/packages.html#packages_conditional_exports
Cheers,
Maxim Kotelnikov