Always upload artifacts (Artificial-Pancreas#36)

Update yml to build with 14.3
Update build_iAPS.yml
Update build_iAPS.yml

.github/workflows/add_identifiers.yml

@@ -13,8 +13,8 @@ jobs:
     runs-on: macos-13
     steps:
       # Uncomment to manually select Xcode version if needed
-      #- name: Select Xcode version
-      #  run: "sudo xcode-select --switch /Applications/Xcode_14.1.app/Contents/Developer"
+      - name: Select Xcode version
+        run: "sudo xcode-select --switch /Applications/Xcode_14.3.app/Contents/Developer"
 
       # Checks-out the repo
       - name: Checkout Repo

.github/workflows/build_iAPS.yml

@@ -56,11 +56,12 @@ jobs:
           FASTLANE_KEY: ${{ secrets.FASTLANE_KEY }}
           MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
 
-      # Upload IPA and Symbols
-      - name: Upload IPA and Symbol artifacts
+      # Upload Build artifacts
+      - name: Upload build log, IPA and Symbol artifacts
+        if: always()
         uses: actions/upload-artifact@v3
         with:
           name: build-artifacts
           path: |
             artifacts
-            buildlog
+            buildlog

fastlane/testflight.md

@@ -40,7 +40,7 @@ This is also a common step for all "browser builds", do this step only once
 If you have previously built Loop or another app using the "browser build" method, you can can re-use your previous personal access token (`GH_PAT`) and skip ahead to `step 2`.
 1. Create a [new personal access token](https://github.com/settings/tokens/new):
     * Enter a name for your token. Something like "FastLane Access Token".
-    * 30 days is fine, or you can select longer if you'd like.
+    * The default Expiration time is 30 days - but you should select `No Expiration`
     * Select the `repo` permission scope.
     * Click "Generate token".
     * Copy the token and record it. It will be used below as `GH_PAT`.
@@ -124,4 +124,4 @@ You do not need to fill out the next form. That is for submitting to the app sto
 1. Your app should eventually appear on [App Store Connect](https://appstoreconnect.apple.com/apps).
 1. For each phone/person you would like to support iAPS on:
     * Add them in [Users and Access](https://appstoreconnect.apple.com/access/users) on App Store Connect.
-    * Add them to your TestFlight Internal Testing group.
+    * Add them to your TestFlight Internal Testing group.