[FIX] Session ls on big databases #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
force-pushed
the
active_session_list
branch
from
251ab85 to
2ea73a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes
251ab85fixes:#71: session ls fails with "Error 1390: Prepared statement contains too many placeholders"#72and#62(1695d4f) as they are mandatory to test.What this PR does / why we need it
If the mySQL database held too many records, the
session lscommand failed with an error message. The hard limit of records by query in mySQL is 65,535.It now queries by batch of 60000 to solve the problem.
I also added an option to only list active session (--active, -a) to compensate for the increased time taken by the query on bigger databases.