Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In gnoclient Render and QEval, need to check Response.Error #19

Merged

Conversation

jefft0
Copy link

@jefft0 jefft0 commented Nov 30, 2023

In a call to ABCIQuery, if the error from the node is not in the err value but in the node response in qres.Response.Error. This includes errors like "invalid package path". The gnoclient method Query already checks for this. We need to do a similar check in the new methods Render and QEval.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8abebbe) 35.37% compared to head (f1059c7) 55.19%.
Report is 111 commits behind head on dev/moul/gnoclient.

Files Patch % Lines
gno.land/pkg/sdk/vm/keeper.go 0.00% 3 Missing ⚠️
gnovm/cmd/gno/lint.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           dev/moul/gnoclient      #19       +/-   ##
=======================================================
+ Coverage               35.37%   55.19%   +19.81%     
=======================================================
  Files                      14      411      +397     
  Lines                    1289    64316    +63027     
=======================================================
+ Hits                      456    35497    +35041     
- Misses                    815    25981    +25166     
- Partials                   18     2838     +2820     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trafico-bot trafico-bot bot added the ✅ Approved Pull Request has been approved and can be merged label Nov 30, 2023
@moul moul merged commit 902c95b into moul:dev/moul/gnoclient Nov 30, 2023
207 of 210 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet ✨ Merged Pull Request has been merged successfully ✅ Approved Pull Request has been approved and can be merged labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants