feat: HTTP caching

cmd/depviz/main.go

@@ -50,6 +50,7 @@ var (
 	serverGodmode            = serverFlags.Bool("godmode", false, "enable dangerous API calls")
 	serverWithPprof          = serverFlags.Bool("with-pprof", false, "enable pprof endpoints")
 	serverWithoutRecovery    = serverFlags.Bool("without-recovery", false, "disable panic recovery (dev)")
+	serverWithoutCache       = serverFlags.Bool("without-cache", false, "disable HTTP caching")
 
 	runFlags            = flag.NewFlagSet("run", flag.ExitOnError)
 	runNoPull           = runFlags.Bool("no-pull", false, "don't pull providers (graph only)")
@@ -290,6 +291,7 @@ func execServer(args []string) error {
 			ShutdownTimeout:    *serverShutdownTimeout,
 			WithPprof:          *serverWithPprof,
 			WithoutRecovery:    *serverWithoutRecovery,
+			WithoutCache:       *serverWithoutCache,
 			Godmode:            *serverGodmode,
 		}
 		svc, err = dvserver.New(ctx, store, schemaConfig, opts)

internal/dvserver/server.go

@@ -22,6 +22,8 @@ import (
 	"github.com/oklog/run"
 	"github.com/rs/cors"
 	chilogger "github.com/treastech/logger"
+	cache "github.com/victorspringer/http-cache"
+	"github.com/victorspringer/http-cache/adapter/memory"
 	"go.uber.org/zap"
 	"google.golang.org/grpc"
 	"moul.io/depviz/internal/chiutil"
@@ -37,6 +39,7 @@ type Opts struct {
 	WithoutRecovery    bool
 	WithPprof          bool
 	Godmode            bool
+	WithoutCache       bool
 }
 
 type Service interface {
@@ -144,7 +147,6 @@ func New(ctx context.Context, h *cayley.Handle, schema *schema.Config, opts Opts
 		r.Use(middleware.Timeout(opts.RequestTimeout))
 		r.Use(middleware.RealIP)
 		r.Use(middleware.RequestID)
-		// FIXME: add caching
 		gwmux := runtime.NewServeMux(
 			runtime.WithMarshalerOption(runtime.MIMEWildcard, &gateway.JSONPb{
 				EmitDefaults: false,
@@ -158,8 +160,31 @@ func New(ctx context.Context, h *cayley.Handle, schema *schema.Config, opts Opts
 			return nil, fmt.Errorf("register service on gateway: %w", err)
 		}
 
+		var handler http.Handler = gwmux
+
 		// api endpoints
-		r.Mount("/api", http.StripPrefix("/api", gwmux))
+		if !opts.WithoutCache {
+			// FIXME: invalidate cache
+			memcached, err := memory.NewAdapter(
+				memory.AdapterWithAlgorithm(memory.LRU),
+				memory.AdapterWithCapacity(10000000),
+			)
+			if err != nil {
+				return nil, fmt.Errorf("memory cache: %w", err)
+			}
+
+			cacheClient, err := cache.NewClient(
+				cache.ClientWithAdapter(memcached),
+				cache.ClientWithTTL(10*time.Minute),
+				cache.ClientWithRefreshKey("opn"),
+			)
+			if err != nil {
+				return nil, fmt.Errorf("cache client: %w", err)
+			}
+
+			handler = cacheClient.Middleware(handler)
+		}
+		r.Mount("/api", http.StripPrefix("/api", handler))
 
 		// pprof endpoints
 		if opts.WithPprof {

internal/githubprovider/model.go

@@ -17,7 +17,7 @@ func fromIssues(issues []*github.Issue, logger *zap.Logger) (dvmodel.Batch, erro
 	for _, issue := range issues {
 		err := fromIssue(&batch, issue)
 		if err != nil {
-			logger.Warn("failed to parse issue", zap.Error(err))
+			logger.Warn("parse issue", zap.String("url", issue.GetHTMLURL()), zap.Error(err))
 			continue
 		}
 	}