Call wp_localize_script directly after enqueueing blocks-frontend-js
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t possible issues, eg when `wp_print_footer_scripts` gets called before the wp_footer action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into an issue with Getwid an TML where TML called
wp_print_footer_scriptsbefore the "wp_footer" action was called. This resulted in the scenario where the localization JS wasn't included in the page.You can call
wp_localize_script( "<script name>" )directly after registering or enqueueing it (eg. on the "enqueue_block_assets" action). That way WordPress handles it all and the additional "wp_footer" hook is not needed.I guess it's safer that way...