Capacity simulation #151
Merged
Capacity simulation #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the list of all events of a vehicle, the capacity simulation yields all ranges of indexes in which a pair of new pickup and dropoff can be inserted without violating any of the capacity constraints
src/capacitySimulation.test.ts
Outdated
| import { capacitySimulation } from './routes/api/whitelist/capacitySimulation'; | ||
|
|
||
| function createEventCapacitiesOnly(capacities: Capacities, is_pickup: boolean): Event { | ||
| const now = new Date(Date.now()); |
There was a problem hiding this comment.
Suggested change
| const now = new Date(Date.now()); | |
| const now = new Date(); |
src/capacitySimulation.test.ts
Outdated
Comment on lines
11
to
14
| passengers: capacities.passengers, | ||
| bikes: capacities.bikes, | ||
| wheelchairs: capacities.wheelchairs, | ||
| luggage: capacities.luggage, |
There was a problem hiding this comment.
Suggested change
| passengers: capacities.passengers, | |
| bikes: capacities.bikes, | |
| wheelchairs: capacities.wheelchairs, | |
| luggage: capacities.luggage, | |
| capacities, |
| passengers: requiredNewEvent.passengers | ||
| }; | ||
| const possibleInsertions: Range[] = []; | ||
| let start: number | undefined = isValid(capacities, current) ? -1 : undefined; |
There was a problem hiding this comment.
Suggested change
| let start: number | undefined = isValid(capacities, current) ? -1 : undefined; | |
| let start: number | undefined = isValid(capacities, current) ? 0 : undefined; |
felixguendling
added a commit
that referenced
this pull request
Sep 11, 2024
* Add capacity simulation Given the list of all events of a vehicle, the capacity simulation yields all ranges of indexes in which a pair of new pickup and dropoff can be inserted without violating any of the capacity constraints * Add tests for capacity simulation * Format * Format * Refactor * fix company test * playwright config: remove while true loop for dev config --------- Co-authored-by: Felix Gündling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.