Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isColorString): cannot convert undefined or null to object #2703

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

kurtextrem
Copy link
Contributor

The current line breaks if the v is null or undefined. TS does not catch it, as Object.prototype.hasOwnProperty.call takes in args of type any (which v is). I assume the type is wrong and should be Exclude<undefined | null, any> instead (but that's a TS issue)

@kurtextrem kurtextrem requested a review from mattgperry June 18, 2024 10:40
@iRevolutionDev
Copy link

Waiting for this fix!!

@mergetron mergetron bot removed the autorebasing label Jul 4, 2024
@mergetron mergetron bot force-pushed the fix/color-string branch from 9536ca9 to 6f597e8 Compare July 4, 2024 13:38
@mergetron mergetron bot merged commit 977f2f0 into main Jul 4, 2024
1 check passed
@mergetron mergetron bot deleted the fix/color-string branch July 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants