-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails on Windows with Lua 5.4 #26
Comments
I had to put in a workaround; https://github.com/lunarmodules/Penlight/blob/59dc58abbea8b16cb28012fae23fb41a4147a84c/appveyor.yml#L22 If just installing "bit32" then LuaRocks would complain that it was natively present in the Lua engine (for Lua 5.2 and Lua 5.3), so had to wrap it in an if statement to only install on Lua 5.4. BTW: @hishamhm is that a LuaRocks issue? |
@Tieske Yes I think this is a LuaRocks issue, I reported it here: luarocks/luarocks#1204 |
Just pushed a PR to @alerque's issue luarocks/luarocks#1218 The weird bit here is why Lua 5.4 is failing with this. |
Is it valid issue? |
This was fixed by luarocks. workaround removal here: lunarmodules/Penlight#375 |
The failure is related to
lua-path
, which has platform specific code. See https://ci.appveyor.com/project/Tieske/penlight/builds/34814130/job/tum1pf3gm3eyh6jrThough I'm not sure whether the fix should be here or in
lua-path
The text was updated successfully, but these errors were encountered: