Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on Windows with Lua 5.4 #26

Closed
Tieske opened this issue Aug 24, 2020 · 6 comments
Closed

Fails on Windows with Lua 5.4 #26

Tieske opened this issue Aug 24, 2020 · 6 comments

Comments

@Tieske
Copy link

Tieske commented Aug 24, 2020

The failure is related to lua-path, which has platform specific code. See https://ci.appveyor.com/project/Tieske/penlight/builds/34814130/job/tum1pf3gm3eyh6jr

Though I'm not sure whether the fix should be here or in lua-path

@Tieske
Copy link
Author

Tieske commented Aug 24, 2020

I had to put in a workaround; https://github.com/lunarmodules/Penlight/blob/59dc58abbea8b16cb28012fae23fb41a4147a84c/appveyor.yml#L22

If just installing "bit32" then LuaRocks would complain that it was natively present in the Lua engine (for Lua 5.2 and Lua 5.3), so had to wrap it in an if statement to only install on Lua 5.4.

BTW: @hishamhm is that a LuaRocks issue?

@alerque
Copy link
Contributor

alerque commented Aug 24, 2020

@Tieske Yes I think this is a LuaRocks issue, I reported it here: luarocks/luarocks#1204

@hishamhm
Copy link

Just pushed a PR to @alerque's issue luarocks/luarocks#1218

The weird bit here is why Lua 5.4 is failing with this.

@moteus
Copy link
Owner

moteus commented Jan 7, 2021

Is it valid issue?
lua-path uses bit32 library only up to Lua 5.3. On Lua 5.3 and newer it uses bit operations.
So not sure how it can be broken by Lua 5.4

Tieske added a commit to lunarmodules/Penlight that referenced this issue Mar 21, 2021
Tieske added a commit to lunarmodules/Penlight that referenced this issue Mar 21, 2021
@Tieske
Copy link
Author

Tieske commented Mar 21, 2021

This was fixed by luarocks.

workaround removal here: lunarmodules/Penlight#375

@Tieske Tieske closed this as completed Mar 21, 2021
@Tieske
Copy link
Author

Tieske commented Mar 21, 2021

thx @hishamhm @alerque @moteus for looking into it.

Tieske added a commit to lunarmodules/Penlight that referenced this issue Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants