Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filepath #194

Merged
merged 4 commits into from
Oct 26, 2019
Merged

Use filepath #194

merged 4 commits into from
Oct 26, 2019

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Oct 25, 2019 •
edited
Loading

Current implementation crash on tests.

=== RUN   TestCommandGet
=== RUN   TestCommandGet/simple
     clone https://github.com/motemen/ghq-test-repo -> C:\Users\mattn\AppData\Local\Temp\ghq-test410163495/github.com/motemen/ghq-test-repo
=== RUN   TestCommandGet/-p_option
     clone ssh://[email protected]/motemen/ghq-test-repo -> C:\Users\mattn\AppData\Local\Temp\ghq-test612581466/github.com/motemen/ghq-test-repo
=== RUN   TestCommandGet/already_cloned_with_-u
    update C:\Users\mattn\AppData\Local\Temp\ghq-test417289713\github.com\motemen\ghq-test-repo
=== RUN   TestCommandGet/shallow
     clone https://github.com/motemen/ghq-test-repo -> C:\Users\mattn\AppData\Local\Temp\ghq-test767359132/github.com/motemen/ghq-test-repo
=== RUN   TestCommandGet/dot_slach_./
  resolved relative ".\\ghq-test-repo" to "https://github.com\\motemen\\ghq-test-repo"
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x8 pc=0x580d51]

goroutine 21 [running]:
testing.tRunner.func1(0xc000156300)
	C:/go/src/testing/testing.go:874 +0x3aa
panic(0x810dc0, 0xbc0920)
	C:/go/src/runtime/panic.go:679 +0x1c0
net/url.(*URL).String(0x0, 0xc000127100, 0x4)
	C:/go/src/net/url/url.go:777 +0x51
github.com/motemen/ghq.TestCommandGet.func5(0xc000156300, 0xc000172300, 0x35, 0xc000105dc0, 0xc0001167c0)
	C:/Users/mattn/go/src/github.com/motemen/ghq/commands_test.go:163 +0x20b
github.com/motemen/ghq.withFakeGitBackend(0xc000156300, 0xc000037080)
	C:/Users/mattn/go/src/github.com/motemen/ghq/commands_test.go:70 +0x31f
github.com/motemen/ghq.TestCommandGet.func7(0xc000156300)
	C:/Users/mattn/go/src/github.com/motemen/ghq/commands_test.go:197 +0x3f
testing.tRunner(0xc000156300, 0xc000116770)
	C:/go/src/testing/testing.go:909 +0xd0
created by testing.(*T).Run
	C:/go/src/testing/testing.go:960 +0x358
exit status 2
FAIL	github.com/motemen/ghq	0.231s

@Songmu Songmu merged commit 94479c2 into x-motemen:master Oct 26, 2019
Songmu added a commit that referenced this pull request Nov 4, 2019
@Songmu
Checking in changes prior to tagging of version v0.12.7
3a4306e 
## [v0.12.7](v0.12.6...v0.12.7) (2019-11-05)

* fix accepted values of ghq.<url>.vcs in README [#196](#196) ([autopp](https://github.com/autopp))
* Use walker [#195](#195) ([mattn](https://github.com/mattn))
* Use filepath [#194](#194) ([mattn](https://github.com/mattn))
* go.{mod,sum}: Update xerrors dependency [#193](#193) ([rvolosatovs](https://github.com/rvolosatovs))
* define func detectUserName and utilize it [#191](#191) ([Songmu](https://github.com/Songmu))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattn @Songmu