Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTECH-2409 Updates to admin bundles #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nickdotreid
Copy link
Contributor

This PR brings in items missing from the admin bundles package, that don't have other tickets.

Added statistics to bundles list, which also meant styling the motech-list header.

added unstyled statistics bar for bundles list

added dl-inline class

moved bundle list into navbar
Added a filter input to the admin bundles list.
<motech-list-header>
<form class="form-inline ">
<div class="form-group">
<label for="admin.bundles.list.filter">{{msg('admin.filter')}}</label>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be {{ 'admin.filter' | translate}} here and in all of the below lines?

@jredlarski
Copy link
Collaborator

@nickdotreid I've checked this PR and filter and showing some statistics about bundles works well.

Are you going to work on how the header of the bundles list looks? I personally don't like the way it is now as the word Filter is above the filter input and maybe it is better to place them next to each other like fields in Email send form or Scheduler jobs form. Furthermore, I would move the statistics to the right to separate them from the filter.

@nickdotreid
Copy link
Contributor Author

@jredlarski -- I was trying to keep with an inline form styling for the filter buttons...

but I'll make the changes you suggested for the sake of consistency...

@jredlarski jredlarski self-assigned this Jul 26, 2016
@jredlarski
Copy link
Collaborator

@nickdotreid I based my opinion on that we used to place some buttons to the left and to the right within motech-list headers and I believe it is not such a bad pattern to place some data in the same way...

@sebbrudzinski
Copy link
Member

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants