Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10: EOF error when sending messages to Confluent Cloud #11

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Issue 10: EOF error when sending messages to Confluent Cloud #11

merged 4 commits into from
Jun 28, 2021

Conversation

fmck3516
Copy link
Contributor

#10

Copy link
Owner

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I suspect that we should pass something to tls.Config, unless you've tested it and it works.

@fmck3516
Copy link
Contributor Author

LGTM! Although I suspect that we should pass something to tls.Config, unless you've tested it and it works.

I tested it - I can publish messages to Confluent Cloud with the empty TLS configuration.

I came across that setting while reading up on how other folks use kafka-go with Confluent Cloud: segmentio/kafka-go#499

@mostafa mostafa merged commit 45ce492 into mostafa:master Jun 28, 2021
mostafa pushed a commit that referenced this pull request May 31, 2022
* issue-10: EOF error when sending messages to Confluent Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants