Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to avoid unnecessary xDS generation for our CRD #719

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

spacewander
Copy link
Member

This change is missed when those CRDs are first added.
Signed-off-by: spacewander [email protected]

This change is missed when those CRDs are first added.
Signed-off-by: spacewander <[email protected]>
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (82b6aa8) to head (26a9cd8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files         128      128           
  Lines        6378     6378           
=======================================
  Hits         5624     5624           
  Misses        544      544           
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacewander spacewander marked this pull request as ready for review September 12, 2024 06:54
@spacewander spacewander merged commit 37f700e into main Sep 19, 2024
16 checks passed
@spacewander spacewander deleted the 912 branch September 19, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant