MOSIP-26586-resident-in-secure-my-id-after-locked-and-unlocked-in-vie…

…w-history-description-is-not-proper (#908)

* fixed id version for document APIs

* update constant names

* used constant file_text

* added validation on req credential API

* added validation for req credential API

* removed duplicate code

* fixed rid status issue

* removed name from enum

* code fix for rid status issue

* update validate request body method

* fixed registration center issue

* added notification in validate otp API

* fixed authentication request description

* removed space

* removed validate otp from auth request service type

* added notification to get my uin API

* added notification in personalised card API

* fixed null check

* refactor code

* fixed code for notify

* code refactoring

* fixed test case failure

* take templatetype code from properties

* fixed preferred language doc error

* fixed code

* renamed variable

* take list from property

* removed unused import

* added comment and changed list to stream

* added photo to attribute list

* fixed update uin summary and purpose

* fixed summary description for share-credential API

* fixed acknowledgement summary purpose

* fixed summary issue

* white spaces

* fixed authentication mode issue

* changed from purpose to attribute list

* fixed db calling multiple times issue

* MOSIP-27036 fixed the summary

* review comments

* removed unused method

* code refactoring

* added cause

* fixed description issue in auth lock unlock API

* added comment

* used contant delimiter

---------

Co-authored-by: Ritik Jain <[email protected]>

resident/resident-service/src/main/java/io/mosip/resident/constant/ResidentConstants.java

@@ -160,6 +160,7 @@ private ResidentConstants() {
 
     public static final String CHANNEL = "channel";
     public static final String ATTRIBUTE_LIST_DELIMITER = ",";
+    public static final String AUTH_TYPE_LIST_DELIMITER = ", ";
 
     public static final String MASK_REQUIRED = "maskRequired";
     public static final String MASK_PREFIX = "masked_";

resident/resident-service/src/main/java/io/mosip/resident/service/impl/ResidentServiceImpl.java

@@ -171,7 +171,6 @@ public class ResidentServiceImpl implements ResidentService {
 	private static final String ONLINE_VERIFICATION_PARTNER = "Online_Verification_Partner";
 	private static final String MOSIP_IDA_PARTNER_TYPE = "mosip.ida.partner.type";
 	private static final int UPDATE_COUNT_FOR_NEW_USER_ACTION_ENTITY = 1;
-	private static final String AUTH_TYPE_LIST_DELIMITER = ", ";
 	private static final String AUTH_TYPE_SEPERATOR = "-";
 	private static final String PROCESSED = "PROCESSED";
 	private static final String DATETIME_PATTERN = "mosip.utc-datetime-pattern";
@@ -1274,7 +1273,7 @@ public Tuple2<ResponseDTO, String> reqAauthTypeStatusUpdateV2(AuthLockOrUnLockRe
 			List<AuthTypeStatusDtoV2> authTypesStatusList = authLockOrUnLockRequestDtoV2.getAuthTypes();
 			String authType = authTypesStatusList.stream().map(dto ->ResidentServiceImpl.getAuthTypeBasedOnConfigV2(dto)
 							+ResidentConstants.COLON+ (dto.getLocked()? LOCKED:UNLOCKED))
-					.collect(Collectors.joining(AUTH_TYPE_LIST_DELIMITER));
+					.collect(Collectors.joining(ResidentConstants.AUTH_TYPE_LIST_DELIMITER));
 
 			Map<String, AuthTypeStatus> authTypeStatusMap = authTypesStatusList.stream()
 					.collect(Collectors.toMap(ResidentServiceImpl::getAuthTypeBasedOnConfigV2,

resident/resident-service/src/main/java/io/mosip/resident/util/TemplateUtil.java

@@ -251,7 +251,7 @@ public String getDescriptionTemplateVariablesForSecureMyId(ResidentTransactionEn
 				fileTextTemplate = fileTextTemplate.replace(ResidentConstants.DOLLAR + ResidentConstants.AUTH_TYPE,
 						templateData);
 				return fileTextTemplate;
-			}).collect(Collectors.joining(ResidentConstants.ATTRIBUTE_LIST_DELIMITER));
+			}).collect(Collectors.joining(ResidentConstants.AUTH_TYPE_LIST_DELIMITER));
 		}
 		return fileText;
 	}