Mosip 18523 perf fixes (#665)

* Add cacheable to uin hash salt repo * Minor refactor * Fix to cache key
mosip · Nov 23, 2021 · 571fd64 · 571fd64
1 parent 5903235
commit 571fd64
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 49 deletions.
diff --git a/...on-common/src/main/java/io/mosip/authentication/common/service/entity/UinEncryptSalt.java b/...on-common/src/main/java/io/mosip/authentication/common/service/entity/UinEncryptSalt.java
diff --git a/...n/src/main/java/io/mosip/authentication/common/service/repository/IdaUinHashSaltRepo.java b/...n/src/main/java/io/mosip/authentication/common/service/repository/IdaUinHashSaltRepo.java
@@ -1,5 +1,7 @@
 package io.mosip.authentication.common.service.repository;
+import static io.mosip.authentication.core.constant.IdAuthCommonConstants.UIN_HASH_SALT;
 
+import org.springframework.cache.annotation.Cacheable;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.query.Param;
@@ -21,6 +23,7 @@ public interface IdaUinHashSaltRepo extends JpaRepository<IdaUinHashSalt, Intege
 	 * @param id the id
 	 * @return String salt
 	 */
+	@Cacheable(cacheNames = UIN_HASH_SALT)
 	@Query("select salt from IdaUinHashSalt where id = :id")
 	public String retrieveSaltById(@Param("id") Integer id);
 }
diff --git a/...ava/io/mosip/authentication/common/service/transaction/manager/IdAuthSecurityManager.java b/...ava/io/mosip/authentication/common/service/transaction/manager/IdAuthSecurityManager.java
@@ -350,7 +350,7 @@ public boolean verifySignature(String signature, String domain, String requestDa
 	 */
 	public String hash(String id) throws IdAuthenticationBusinessException {
 		int saltModuloConstant = env.getProperty(IdAuthConfigKeyConstants.UIN_SALT_MODULO, Integer.class);
-		Integer idModulo = (int)(Long.parseLong(id) % saltModuloConstant);
+		Integer idModulo = getModulo(id, saltModuloConstant);
 		String hashSaltValue = uinHashSaltRepo.retrieveSaltById(idModulo);
 		if (hashSaltValue != null) {
 			try {
@@ -365,6 +365,10 @@ public String hash(String id) throws IdAuthenticationBusinessException {
 		}
 	}
 
+	private int getModulo(String id, int saltModuloConstant) {
+		return (int)(Long.parseLong(id) % saltModuloConstant);
+	}
+
 	/**
 	 * Gets the x 509 certificate.
 	 *

diff --git a/...ation-core/src/main/java/io/mosip/authentication/core/constant/IdAuthCommonConstants.java b/...ation-core/src/main/java/io/mosip/authentication/core/constant/IdAuthCommonConstants.java
@@ -319,6 +319,9 @@ public final class IdAuthCommonConstants {
 	public static final String FAILURE = "failure";
 
 	public static final String QUALITY_SCORE = "qualityScore";
+
+	public static final String UIN_HASH_SALT = "uin_hash_salt";
+
 
 
 	private IdAuthCommonConstants() {