Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error msg when checking target_blocks overlap #977

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Improve error msg when checking target_blocks overlap #977

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f386ea
improve error msg when checking target_blocks in activation_checkpoin…
cli99 Feb 14, 2024
a7e2e6f
Update llmfoundry/models/utils/act_ckpt.py
dakinggg Feb 15, 2024
e5b4cfd
Merge branch 'main' into improve-act-ckpt-msg
dakinggg Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llmfoundry/models/utils/act_ckpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def check_mapping_blocks_overlap(mapping: dict, max_block_idx: int) -> None:
else:
if all_blocks[vv] is not None:
raise ValueError(
f'Block {vv} is assigned to both {k} and {all_blocks[vv]}.'
f'Block {vv} is assigned to both {k} and {all_blocks[vv]}. Each block can only have one granularity of activation checkpointing. Make sure the target_blocks in activation_checkpointing_target do not overlap. For more details, refer to the docs of activation_checkpointing_fn.'
)
else:
all_blocks[vv] = k
Expand Down
Loading