Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up resolve_ffn_hidden_and_exp_ratio #801

Merged
merged 2 commits into from
Dec 13, 2023
Merged

clean up resolve_ffn_hidden_and_exp_ratio #801

merged 2 commits into from
Dec 13, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Dec 13, 2023 •
edited
Loading

Hot fix cleanup to #796. Fixes:

  • Make resolve_ffn_hidden_and_exp_ratio not private (there are other places one could use the fn; eg here)
  • resolve_ffn_hidden_and_exp_ratio would return expansion_ratio without modifying it; given its already an input, this return is superfluous.

dakinggg
dakinggg approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed it on the last PR, but could you add a simple test that tests setting ffn_hidden_size directly?

@vchiley vchiley merged commit 5fdcc43 into mosaicml:main Dec 13, 2023
8 checks passed
@vchiley vchiley deleted the rm_extra_return branch December 13, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea left review comments

@dakinggg dakinggg dakinggg approved these changes

@sashaDoubov sashaDoubov Awaiting requested review from sashaDoubov

@ShashankMosaicML ShashankMosaicML Awaiting requested review from ShashankMosaicML

@josejg josejg Awaiting requested review from josejg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchiley @irenedea @dakinggg