Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra test suite #743

Merged
merged 37 commits into from
Nov 20, 2023
Merged

Remove extra test suite #743

merged 37 commits into from
Nov 20, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Nov 16, 2023 •
edited
Loading

  • Removes the 2.0.1 test suites to reduce test load. Just tests 1.13 and 2.1 now
  • Lots of speed ups to the tests by changing test parameters and removing redundant/unnecessary tests
  • Fixes a bug where auto packing didn't work on torch 1.13 (didn't catch because we moved "latest" to 2.1, which accidentally removed our 1.13 test suite
  • Resolve a few random warnings
  • We were accidentally overriding the flash attention install in the tests, so flash2 wasn't actually getting tested (although I had run the tests locally when I originally added flash2)

Tests run in under 10 minutes now.

There is a non zero chance that the tests fail after I merge this PR because of the changes to GPU workflow files, which don't get picked up for CI on this PR, but I've run the tests locally, and will just monitor and fast fix after this PR if needed.

Will adjust the "required" checks after this PR is in.

@dakinggg dakinggg marked this pull request as ready for review November 19, 2023 05:50
irenedea
irenedea reviewed Nov 19, 2023
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Added some comments

llmfoundry/models/mpt/configuration_mpt.py Show resolved Hide resolved
tests/test_dataloader.py Show resolved Hide resolved
scripts/data_prep/convert_dataset_hf.py Show resolved Hide resolved
scripts/eval/local_data/world_knowledge/triviaqa_small.jsonl Show resolved Hide resolved
tests/test_packing.py Show resolved Hide resolved
tests/test_lion8b.py Show resolved Hide resolved
tests/test_hf_conversion_script.py Outdated Show resolved Hide resolved
@dakinggg dakinggg merged commit 437fc55 into mosaicml:main Nov 20, 2023
11 checks passed
@dakinggg dakinggg deleted the remove-test-suites branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea left review comments

@j316chuck j316chuck j316chuck left review comments

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dakinggg @j316chuck @irenedea @mvpatel2000