Fix logging verbosity in HF model download script and repair symlinks #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrychen109
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily suppresses
InvalidCertWarningwhen downloading a HF model from a cache server withignore_cert=True, as the warnings are quite noisy. In addition, it also sets the default log level toINFOin the download script so the logging is actually visible.Also modifies the script to call
download_from_hf_hubeven after a successful cache download for the purpose of repairing the Hugging Face symlinks to address a non-deterministic bug where the symlinks aren't properly repaired by the time composer loads the model.Tested a run downloading MPT-7B from a cache server using the new commit
94eff5bae6210865e0a7ee60fe2ec7eba4750522. Note the no-op forFetching 24 filesresulting from the download from HF after:And successful model initialization:
