Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unity Catalog support to HF checkpointer #721

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Nov 8, 2023

Uses our helper function to support all our supported uris, allowing saving to UC.

Manually tested:

  • Writing to s3 still works: s3save-after-maybe-2-Fy4YhU
  • Writing to UC works: ucsave-after-maybe-3-8ZR8qh (It doesn't actually work because we're having some issues writing large files to UC, but it mechanically works in that it tries to write to the correct place and some of the files make it.

@dakinggg dakinggg marked this pull request as ready for review November 8, 2023 01:29
@dakinggg dakinggg marked this pull request as draft November 8, 2023 01:53
@dakinggg dakinggg marked this pull request as ready for review November 8, 2023 02:09
Copy link

@panchalhp-db panchalhp-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@dakinggg dakinggg enabled auto-merge (squash) November 9, 2023 18:06
@dakinggg dakinggg merged commit d2ddb83 into mosaicml:main Nov 9, 2023
12 checks passed
@dakinggg dakinggg deleted the uc-hf branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants