-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix passed metadata to mlflow logging #713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you take this opportunity to improve our test coverage too? :D I'm thinking just checking that things are called with the correct args here instead of just testing that the function is called
wenfeiy-db
force-pushed
the
fix-mlflow-log
branch
from
November 8, 2023 20:10
c714799
to
94e3515
Compare
wenfeiy-db
changed the title
Set task if the passed metadata does not include task
[DO NOT MERGE] Set task if the passed metadata does not include task
Nov 9, 2023
wenfeiy-db
changed the title
[DO NOT MERGE] Set task if the passed metadata does not include task
Fix passed metadata to mlflow logging
Nov 14, 2023
@dakinggg Could you take another look? Tests added and CI is good! |
dakinggg
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
mlflow_logging_config
is an omegaconfig DictConfig, which is not serializable by yaml and will cause mlflow logging to fail if metadata is passed there. This PR convert it to python native dict inbuild_callbacks
.task
key inmetadata
as long asmetatdata
is passed inmlflow_logging_config
. However, it's possible for the client to pass ametatdata
inmlflow_logging_config
that doesn't includetask
key. In this case, we should keep other metadata and set thetask
.