Bugfix auto packing with streams + no remote path #1679
Merged
+63
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Edge case where auto packing fails for a streaming dataset specified through
streams
field if only a local path and no remote path is provided. This configuration is more broadly supported for Foundry.An error is thrown in StreamingDataset init because there is a check that
local
contains an index file. The current auto packing script overwriteslocal
with an empty tempdir. This fix temporarily hasremote
point to the user-providedlocal
, which should contain an index file.Testing